Genetics of 1000 seed weight and oil content was studied in F1 and F2 generations of a 20 parents partial diallel analysis (5=7) in yellow sarson. Non additive gene effect was important in the inheritance of these characters. Parents AJL17 for 1000-seed weight and AJL6 and AJL64 for oil content were the good general combiners in both the generations. The use of these genotypes in future breeding programme is advocated.